diff options
| author | Michael Elkins <melkins@tislabs.com> | 2014-11-26 22:10:53 +0000 |
|---|---|---|
| committer | Michael Elkins <melkins@tislabs.com> | 2014-11-26 22:10:53 +0000 |
| commit | c0d2779fdd8b002ef90c6204e5a755325566feaa (patch) | |
| tree | 18abafd2dfb9946bad152ec0e644a891be309744 /rpki | |
| parent | 8f2e9a7f7a7761d34253986d912129fadf7e7ce2 (diff) | |
check formset.has_changed() in roa creation form to detect submission of blank form. closes #734
svn path=/trunk/; revision=6037
Diffstat (limited to 'rpki')
| -rw-r--r-- | rpki/gui/app/views.py | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/rpki/gui/app/views.py b/rpki/gui/app/views.py index dfd36dbb..f7492434 100644 --- a/rpki/gui/app/views.py +++ b/rpki/gui/app/views.py @@ -708,7 +708,10 @@ def roa_create_multi(request): formset = formset_factory(forms.ROARequestFormFactory(conf), extra=extra)(initial=init) elif request.method == 'POST': formset = formset_factory(forms.ROARequestFormFactory(conf), extra=0)(request.POST, request.FILES) - if formset.is_valid(): + # We need to check .has_changed() because .is_valid() will return true + # if the user clicks the Preview button without filling in the blanks + # in the ROA form, leaving the form invalid from this view's POV. + if formset.has_changed() and formset.is_valid(): routes = [] v = [] for form in formset: |