From 9f6d6462a9cef37735a9d4c61921d04934fd9864 Mon Sep 17 00:00:00 2001 From: Rob Austein Date: Wed, 11 Nov 2015 03:22:38 +0000 Subject: Configure pylint to use the pylint-django plugin, which (mostly) understands Django's exotic metaclasses, which in turn allows us to re-enable a number of pylint checks we had disabled. While we were at this, stripped out a bunch of old pylint pragmas, then added back the subset that were really needed. As usual with pylint, this turned up a few real bugs along with an awful lot of noise. svn path=/branches/tk705/; revision=6162 --- rpki/django_settings/common.py | 2 ++ rpki/django_settings/gui.py | 2 +- rpki/django_settings/irdb.py | 2 +- rpki/django_settings/pubd.py | 2 +- rpki/django_settings/rpkid.py | 2 +- 5 files changed, 6 insertions(+), 4 deletions(-) (limited to 'rpki/django_settings') diff --git a/rpki/django_settings/common.py b/rpki/django_settings/common.py index 13dcdcef..4aa3e119 100644 --- a/rpki/django_settings/common.py +++ b/rpki/django_settings/common.py @@ -57,6 +57,8 @@ if os.getenv("RPKI_DJANGO_DEBUG") == "yes": class DatabaseConfigurator(object): default_sql_engine = "mysql" + cfg = None + section = None def configure(self, cfg, section): # pylint: disable=W0621 self.cfg = cfg diff --git a/rpki/django_settings/gui.py b/rpki/django_settings/gui.py index 4e9ac0f3..2c664f91 100644 --- a/rpki/django_settings/gui.py +++ b/rpki/django_settings/gui.py @@ -20,7 +20,7 @@ This module contains GUI-specific configuration settings for Django libraries. # Pull in the irdb configuration, which in turn pulls in the common configuration. -from .irdb import * # pylint: disable=W0401 +from .irdb import * # pylint: disable=W0401,W0614 __version__ = "$Id$" diff --git a/rpki/django_settings/irdb.py b/rpki/django_settings/irdb.py index 2a49739b..da42a111 100644 --- a/rpki/django_settings/irdb.py +++ b/rpki/django_settings/irdb.py @@ -21,7 +21,7 @@ the GUI code also uses this but adds a bunch of other stuff, thus has its own settings file. """ -from .common import * # pylint: disable=W0401 +from .common import * # pylint: disable=W0401,W0614 __version__ = "$Id$" diff --git a/rpki/django_settings/pubd.py b/rpki/django_settings/pubd.py index 0df0ddb9..6bd9fdc0 100644 --- a/rpki/django_settings/pubd.py +++ b/rpki/django_settings/pubd.py @@ -19,7 +19,7 @@ This module contains configuration settings for Django libraries for the pubd program. """ -from .common import * # pylint: disable=W0401 +from .common import * # pylint: disable=W0401,W0614 __version__ = "$Id$" diff --git a/rpki/django_settings/rpkid.py b/rpki/django_settings/rpkid.py index 70987315..e34518bb 100644 --- a/rpki/django_settings/rpkid.py +++ b/rpki/django_settings/rpkid.py @@ -19,7 +19,7 @@ This module contains configuration settings for Django libraries for the rpkid program. """ -from .common import * # pylint: disable=W0401 +from .common import * # pylint: disable=W0401,W0614 __version__ = "$Id$" -- cgit v1.2.3