diff options
| author | Rob Austein <sra@hactrn.net> | 2015-11-11 03:22:38 +0000 |
|---|---|---|
| committer | Rob Austein <sra@hactrn.net> | 2015-11-11 03:22:38 +0000 |
| commit | 9f6d6462a9cef37735a9d4c61921d04934fd9864 (patch) | |
| tree | e5d1b046f6f6bd44faf1b5028f6f1df9698e2a88 /buildtools | |
| parent | ac415cdd0f88f8479975627772dd0a84797b261a (diff) | |
Configure pylint to use the pylint-django plugin, which (mostly)
understands Django's exotic metaclasses, which in turn allows us to
re-enable a number of pylint checks we had disabled. While we were at
this, stripped out a bunch of old pylint pragmas, then added back the
subset that were really needed. As usual with pylint, this turned up
a few real bugs along with an awful lot of noise.
svn path=/branches/tk705/; revision=6162
Diffstat (limited to 'buildtools')
| -rw-r--r-- | buildtools/make-relaxng.py | 2 | ||||
| -rw-r--r-- | buildtools/pylint.rc | 19 |
2 files changed, 18 insertions, 3 deletions
diff --git a/buildtools/make-relaxng.py b/buildtools/make-relaxng.py index 3d239e8a..a8b562fa 100644 --- a/buildtools/make-relaxng.py +++ b/buildtools/make-relaxng.py @@ -26,6 +26,8 @@ import sys header = """\ # Automatically generated, do not edit. +# pylint: skip-file + from rpki.relaxng_parser import RelaxNGParser """ diff --git a/buildtools/pylint.rc b/buildtools/pylint.rc index 1c57aa22..ac893ad6 100644 --- a/buildtools/pylint.rc +++ b/buildtools/pylint.rc @@ -24,11 +24,13 @@ profile=no # making ten zillion cosmetic changes in a co-worker's code on a # long-running development branch. -ignore=.svn,.git,migrations,south_migrations,irbe_cli,gui +ignore=.svn,.git,migrations,south_migrations,gui persistent=yes cache-size=500 -load-plugins= + +# We make heavy use of Django, which confuses pylint. Fortunately, there's a plug-in. +load-plugins=pylint_django # Extension (C, etc) modules that pylint should trust enough to import. @@ -54,7 +56,18 @@ disable-msg-cat= #enable-msg= # Disable the message(s) with the given id(s). -disable=R0801,R0903,R0913,C0321,R0904,W0201,E1101,W0614,C0301,R0901,C0302,R0902,R0201,W0613,R0912,R0915,W0703,W0212,R0914,W0603,W0142,I0011,C0111,C0103,R0401,C0326,R0911,C0325,C0330,W0311,E1124,W0702 +# +# I0011 is (sort of) special, in that it marks places where we've used +# inline overrides in the code to control pylint's behavior. +# Ordinarily we leave this turned off, but it's a good idea to run +# with it enabled every once in a while to see what we've overriden. +# +disable=I0011,I0013,R0801,C0111,C0301,C0326,W0702,R0902,R0913,W0703,R0912,R0903,R0915,R0914,C0302,W0613,R0201,R0901,R0904,C0325,R0911,C0103,R0401 +# +# Additional messages we used to have disabled but now appear to be +# able to leave alone. +# +#disable=C0321,W0201,E1101,W0614,W0212,W0603,W0142,C0330,W0311,E1124 [REPORTS] |