aboutsummaryrefslogtreecommitdiff
path: root/rcynic
diff options
context:
space:
mode:
authorRob Austein <sra@hactrn.net>2013-06-27 02:02:06 +0000
committerRob Austein <sra@hactrn.net>2013-06-27 02:02:06 +0000
commit9d3e898bbe429f8220f1b9c4498ea3454588219d (patch)
tree35f10136204ee8da56aca26233b1a5dc810cabc2 /rcynic
parentad2ce5f27d8dd14b8f333768f52dd13670b70d12 (diff)
Flip default for allow-object-not-in-manifest to false.
svn path=/trunk/; revision=5418
Diffstat (limited to 'rcynic')
-rw-r--r--rcynic/rcynic.c13
1 files changed, 7 insertions, 6 deletions
diff --git a/rcynic/rcynic.c b/rcynic/rcynic.c
index fddbf369..404a245f 100644
--- a/rcynic/rcynic.c
+++ b/rcynic/rcynic.c
@@ -294,6 +294,7 @@ static const struct {
QW(nonconformant_subject_name, "Nonconformant X.509 subject name") \
QW(rsync_partial_transfer, "rsync partial transfer") \
QW(rsync_transfer_skipped, "rsync transfer skipped") \
+ QW(skipped_because_not_in_manifest, "Skipped because not in manifest") \
QW(stale_crl_or_manifest, "Stale CRL or manifest") \
QW(tainted_by_stale_crl, "Tainted by stale CRL") \
QW(tainted_by_stale_manifest, "Tainted by stale manifest") \
@@ -4944,16 +4945,17 @@ static void walk_cert(rcynic_ctx_t *rc, void *cookie)
continue; /* CRLs and manifests checked elsewhere */
}
- if (hash == NULL)
- log_validation_status(rc, &uri, tainted_by_not_being_in_manifest, generation);
- else if (w->stale_manifest)
- log_validation_status(rc, &uri, tainted_by_stale_manifest, generation);
-
if (hash == NULL && !rc->allow_object_not_in_manifest) {
+ log_validation_status(rc, &uri, skipped_because_not_in_manifest, generation);
walk_ctx_loop_next(rc, wsk);
continue;
}
+ if (hash == NULL)
+ log_validation_status(rc, &uri, tainted_by_not_being_in_manifest, generation);
+ else if (w->stale_manifest)
+ log_validation_status(rc, &uri, tainted_by_stale_manifest, generation);
+
if (endswith(uri.s, ".roa")) {
check_roa(rc, wsk, &uri, hash, hashlen);
walk_ctx_loop_next(rc, wsk);
@@ -5446,7 +5448,6 @@ int main(int argc, char *argv[])
rc.allow_stale_manifest = 1;
rc.allow_digest_mismatch = 1;
rc.allow_crl_digest_mismatch = 1;
- rc.allow_object_not_in_manifest = 1;
rc.allow_nonconformant_name = 1;
rc.allow_ee_without_signedObject = 1;
rc.allow_1024_bit_ee_key = 1;